Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh cache after update #125

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Refresh cache after update #125

merged 1 commit into from
Jul 10, 2018

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Jun 27, 2018

Close #121

@yesmeck yesmeck requested a review from paranoidjk June 27, 2018 09:34
@yesmeck
Copy link
Member Author

yesmeck commented Jun 27, 2018 •
edited
Loading

@eternalsky 帮忙看下

@yesmeck yesmeck requested a review from afc163 June 27, 2018 09:52
afc163
afc163 reviewed Jun 27, 2018
View reviewed changes
src/SwipeableTabBarMixin.js Outdated
this.setSwipePositionByKey(activeKey);
},
componentWillReceiveProps(nextProps) {
if (nextProps.activeKey && nextProps.activeKey !== this.props.activeKey) {
this.setSwipePositionByKey(nextProps.activeKey);
}
},
componentDidUpdate() {
this.setCache();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉这个 cache 其实提升不了多少性能。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其实只是一个实例变量来记中间状态

@yesmeck yesmeck changed the title Reresh cache after update [WIP]Reresh cache after update Jun 27, 2018
@yesmeck yesmeck changed the title [WIP]Reresh cache after update Reresh cache after update Jun 27, 2018
@eternalsky
Copy link

感觉没什么问题，cache 可以被更新了。

@yesmeck yesmeck changed the title Reresh cache after update Refresh cache after update Jun 27, 2018
@eternalsky
Copy link

这个 pr 现在还有什么问题吗~ 可以合并了吗~

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 63.802% when pulling 966fc37 on fix-cache into a6b82cd on master.

@yesmeck yesmeck merged commit 9dd23e9 into master Jul 10, 2018
@yesmeck yesmeck deleted the fix-cache branch July 10, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@paranoidjk paranoidjk Awaiting requested review from paranoidjk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yesmeck @eternalsky @coveralls @afc163