Fix clone and restore for invalid non colliding cache #1455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Issue
Clone
or kinbodysaver's restoring is called while_isListNonCollidingLinksValid
is false,Grabbed
's internal savers are inconsistent.Grabbed
has savers at the configurationA
.B
.Clone
orKinBodyStateSaver::Restore(pbody)
.Grabbed
instance is created for the cloned/restored body. But, the newly createdGrabbed
has savers at the configurationB
. Since the original saver is at the configurationA
, the derivedlistNonCollidingLinks
are different between the original one and the new one.Resolution
Grabbed
to copy the saver's states from otherGrabbed
.KinBodyStateSaver
andRobotStateSaver
, to copy the states from other savers.Saver
options. It only supports the copy-able states without deep copy. If the state is pointer, the copying of it might not be always expected.Discussion
Grabbed
. But, it looks still tricky and the computation time for it is not small. So, in this PR, i'm trying to simply copy theKinBodyStateSaver
's state itself.