feat(netcore): add tests for WrapConn #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let us make sure WrapConn correctly wraps the underlying netx and correctly deals with the conn returnning nil addresses w/o crashing, which is a pathologic edge case to keep into account. While there, ensure the `maybeWrapConn` method correctly sets the wrapper's netx field, so we are sure logging will happen when it has been configured inside of the network we're passing as argument. While there, make tests names more consistent with respect to whether funcs are public or private, and whether they are methods or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let us make sure WrapConn correctly wraps the underlying netx and correctly deals with the conn returnning nil addresses w/o crashing, which is a pathologic edge case to keep into account.
While there, ensure the
maybeWrapConnmethod correctly sets the wrapper's netx field, so we are sure logging will happen when it has been configured inside of the network we're passing as argument.While there, make tests names more consistent with respect to whether funcs are public or private, and whether they are methods or not.