Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: slog: {r => dnsR}aw{Query,Response} #7

Merged
merged 2 commits into from
Nov 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/spec/data-format/df-000-dns.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
| | |
|--------------|------------------------------------------------|
| Author | [@bassosimone](https://github.com/bassosimone) |
| Last-Updated | 2024-11-22 |
| Last-Updated | 2024-11-29 |

This document describes the format of DNS measurements emitted
by [rbmk](https://github.com/rbmk-project/rbmk) and implemented by
Expand Down Expand Up @@ -73,7 +73,7 @@ The JSON serialization of the query message contains
```JSON
{
"msg":"dnsQuery",
"rawQuery":"",
"dnsRawQuery":"",
"serverAddr":"",
"serverProtocol":"",
"t":""
Expand All @@ -85,7 +85,7 @@ Where:
- `"msg"` (string) is the message type and is
always equal to `"dnsQuery"`;

- `"rawQuery"` (base64 string) contains the
- `"dnsRawQuery"` (base64 string) contains the
raw DNS query in base64 encoding;

- `"serverAddr"` (string) is the address of the
Expand All @@ -112,8 +112,8 @@ The JSON serialization of the response message contains
{
"msg":"dnsResponse",
"localAddr": "",
"rawQuery":"",
"rawResponse":"",
"dnsRawQuery":"",
"dnsRawResponse":"",
"remoteAddr": "",
"serverAddr":"",
"serverProtocol":"",
Expand All @@ -130,10 +130,10 @@ always equal to `"dnsQuery"`;
- `"localAddr"` (string) local address and port
of the socket we're using;

- `"rawQuery"` (string) contains the
- `"dnsRawQuery"` (string) contains the
raw DNS query in base64 encoding;

- `"rawResponse"` (string) contains the
- `"dnsRawResponse"` (string) contains the
raw DNS response in base64 encoding;

- `"remoteAddr"` (string) remote address and port
Expand Down Expand Up @@ -164,7 +164,7 @@ Here is an example of a `"dnsQuery"` message:
```JSON
{
"msg":"dnsQuery",
"rawQuery":"yHUBAAABAAAAAAABA3d3dwdleGFtcGxlA2NvbQAAAQABAAApBNAAAAAAAAA=",
"dnsRawQuery":"yHUBAAABAAAAAAABA3d3dwdleGFtcGxlA2NvbQAAAQABAAApBNAAAAAAAAA=",
"serverAddr":"8.8.8.8:53",
"serverProtocol":"udp",
"t":"2024-11-18T15:31:53.05491+01:00",
Expand All @@ -177,8 +177,8 @@ Here is an example of a `"dnsResponse"` message:
{
"msg":"dnsResponse",
"localAddr": "130.192.91.211:32769",
"rawQuery":"yHUBAAABAAAAAAABA3d3dwdleGFtcGxlA2NvbQAAAQABAAApBNAAAAAAAAA=",
"rawResponse":"yHWBgAABAAEAAAABA3d3dwdleGFtcGxlA2NvbQAAAQABwAwAAQABAAANVAAEXbjXDgAAKQIAAAAAAAAA",
"dnsRawQuery":"yHUBAAABAAAAAAABA3d3dwdleGFtcGxlA2NvbQAAAQABAAApBNAAAAAAAAA=",
"dnsRawResponse":"yHWBgAABAAEAAAABA3d3dwdleGFtcGxlA2NvbQAAAQABwAwAAQABAAANVAAEXbjXDgAAKQIAAAAAAAAA",
"remoteAddr": "8.8.8.8:53",
"serverAddr":"8.8.8.8:53",
"serverProtocol":"udp",
Expand Down