fix(blade): focus on selected date by default in datepicker #2567
Conversation
🦋 Changeset detectedLatest commit: b82c1eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ PR title follows Conventional Commits specification. |
tewarig
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b82c1eb:
|
Bundle Size ReportUpdated Components
|
tewarig
requested review from
chaitanyadeorukhkar,
kamleshchandnani,
anuraghazra,
snitin315 and
saurabhdaware
as code owners
| @@ -64,7 +66,18 @@ const Calendar = <Type extends DateSelectionType>({ | |||
|
|
|||
| const dateContext = useDatesContext(); | |||
| const isMobile = useIsMobile(); | |||
| const currentDate = _date ?? shiftTimezone('add', new Date()); | |||
| const currentDate = React.useMemo(() => { | |||
There was a problem hiding this comment.
Can you explain whats happening here? the date prop as is should work?
There was a problem hiding this comment.
We are already using dateProp. Currently, _date is passed to Date.
Whenever the user clicks on the next month/year, we update _date, and the date picker focuses on _date.
I modified this logic slightly:
- If _date exists, focus on it.
- Otherwise, focus on oldValue.
- If oldValue is also unavailable, focus on currentDate.
There was a problem hiding this comment.
It's the last applied value in the date picker.
Whenever you click/select any value on the date picker, its value changes. But if you click on Cancel, we revert back to the older value using oldValue. When you click on Apply, we save the applied value in oldValue to retrieve it next time.
Description
ref
Changes
Additional Information
Component Checklist