Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import statements throughout codebase #25

Closed
ray-chew opened this issue Mar 22, 2024 · 1 comment · Fixed by #26
Closed

Fix import statements throughout codebase #25

ray-chew opened this issue Mar 22, 2024 · 1 comment · Fixed by #26
Assignees
@ray-chew
Labels
infrastructure All infrastructure needs go here Priority Helps to filter out the important issues
Milestone
Refactor

Comments

@ray-chew
Copy link
Owner

Mustn't import functions and classes directly...
@ray-chew ray-chew added the infrastructure All infrastructure needs go here label Mar 22, 2024
@ray-chew ray-chew added this to the Refactor milestone Mar 22, 2024
@ray-chew ray-chew self-assigned this Mar 22, 2024
@ray-chew ray-chew changed the title Fix import statements through Fix import statements throughout codebase Mar 22, 2024
@ray-chew ray-chew added the Priority Helps to filter out the important issues label Mar 23, 2024
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
standardised import statements in inputs, run_scripts, and data_assim…
4d83eca 
…ilation #25

untested, may contain typos
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
standardised import statements in dycore.dicretisation #25
f950ece 
tested; runs
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
fixed typos in data_assimilation.blending #25
9342503
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
standardised import statements in dycore.physics and dycore.utils #25
6648cc5 
tested; runs
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
standardised import statements in tests, utils, and vis #25
223b062 
tested and runs; updated function names in dycore.physics.hydrostatic
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
fixed typo in dycore.discretisation.grid #25
58d0800
ray-chew added a commit that referenced this issue Mar 23, 2024
@ray-chew
standardised import statements in __main__.py #25
09266bd 
tested and runs; updated function names in dycore.physics.gas_dynamics.thermodynamic, utils.io, and data_assimilation.params
@ray-chew
Copy link
Owner Author

Completed; I have not tested the modules in the data_assimilation subpackage, though.

@ray-chew ray-chew linked a pull request Mar 23, 2024 that will close this issue
Restructured code for move_repo milestone #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ray-chew ray-chew

Labels
infrastructure All infrastructure needs go here Priority Helps to filter out the important issues
Projects
None yet
Milestone
Refactor
Development

Successfully merging a pull request may close this issue.

Restructured code for move_repo milestone ray-chew/pyBELLA
1 participant
@ray-chew