Fix menu toggle callback related issue

rasitayaz · Oct 23, 2021 · 18d3538 · 18d3538
1 parent ae16796
commit 18d3538
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
+## 0.0.5
+
+* Fixed `onMenuToggle` callback of `PieMenu` is not being called when the canvas callback is null.
+
 ## 0.0.4
 
-* `onMenuToggle` callback at the `PieCanvas` also added for the `PieMenu`.
+* `onMenuToggle` callback at `PieCanvas` also added for `PieMenu`.
 
 ## 0.0.3
 

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -120,7 +120,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "0.0.4"
+    version: "0.0.5"
   plugin_platform_interface:
     dependency: transitive
     description:

diff --git a/lib/src/displayed_canvas.dart b/lib/src/displayed_canvas.dart
@@ -341,18 +341,18 @@ class DisplayedCanvasState extends State<DisplayedCanvas>
   }
 
   void toggleMenu(bool menuVisible) {
+    if (_onActiveMenuToggle != null) {
+      _onActiveMenuToggle!(menuVisible);
+    }
     if (widget.onMenuToggle != null) {
-      if (_onActiveMenuToggle != null) {
-        _onActiveMenuToggle!(menuVisible);
-      }
       widget.onMenuToggle!(menuVisible);
-      if (menuVisible) {
-        WidgetsBinding.instance!.addPostFrameCallback((duration) {
-          /// This rebuild prevents menu child being displayed
-          /// in the wrong offset when the scrollable swiped fast.
-          setState(() {});
-        });
-      }
+    }
+    if (menuVisible) {
+      WidgetsBinding.instance!.addPostFrameCallback((duration) {
+        /// This rebuild prevents menu child being displayed
+        /// in the wrong offset when the scrollable swiped fast.
+        setState(() {});
+      });
     }
   }
 

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: pie_menu
 description: A customizable Flutter library that provides a circular context menu.
-version: 0.0.4
+version: 0.0.5
 homepage: https://github.com/RasitAyaz/flutter-pie-menu
 
 environment: