Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conda-build instead of conda-mambabuild #378

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Feb 25, 2025

This changes from conda mambabuild to conda build. Conda now uses the mamba solver so no performance regressions are expected.

This is a temporary change as we plan to migrate to rattler-build in the near future. However, this is needed sooner to drop boa and unblock Python 3.13 migrations.

xref: rapidsai/build-planning#149

@bdice bdice requested a review from a team as a code owner February 25, 2025 20:17
@bdice bdice requested a review from jameslamb February 25, 2025 20:17
@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 25, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll note here (haven't in the other reviews), I've also been spot-checking that sccache is still working and yeah, looks fine.

Compile requests                    186
Compile requests executed           186
Cache hits                          186
Cache hits (c [gcc])                 21
Cache hits (c++ [gcc])              165

(build link)

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 0ae4ed4 into rapidsai:branch-0.43 Feb 25, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants