Test Cython code exposed externally #376
Conversation
pentschev
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Expose class structure in `libucxx.pxd`. This change is useful so that projects building on top of the Python interface can take `shared_ptr<ucxx::Component>` objects and plug those objects into their C++ backends. Although it's not possible to define private attributes in a `cdef class`, we attempt to mark them private with the leading underscore in their names, such as `UCXContext._context`, and then provide a `UCXContext.get_ucxx_shared_ptr` for those members that are expected to be externally usable. Testing will be handled as part of #376. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Lawrence Mitchell (https://github.com/wence-) URL: #372
|
/ok to test |
|
/ok to test |
|
/ok to test |
| clean - remove all existing build artifacts and configuration (start | ||
| over) | ||
| libucxx - build the UCXX C++ module | ||
| libucxx_python - build the UCXX C++ Python support module | ||
| ucxx - build the ucxx Python package | ||
| ucxx_tests - build the ucxx Cython tests |
There was a problem hiding this comment.
Maybe change to --cython-tests ?
There was a problem hiding this comment.
I'm here attempting to match the name of the conda package we're creating to have installable tests. I agree this isn't the best name but there's so much mismatch currently that's hard to keep track of all that. On that note, I think it makes sense to rename those variables to include the prefix libucxx_ and match also the existing package names like libucxx-tests, so I've done that in b7c3d42 but kept the name here to ucxx_tests in an attempt to make things more consistent for now.
This is a follow-up for #372 that exposed certain parts of the Cython API for external usage. In this PR, proper tests are added, including the require infrastructure to build the tests and run in CI.