Use new rapids-logger library #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
vyasr
force-pushed
the
feat/rapids_logger_library
branch
from
4d461a9 to
2ebc5e7
Compare
|
/ok to test |
|
/ok to test |
|
/ok to test |
This reverts commit edc6f63.
…test jobs to pull as well.
|
/ok to test |
|
/ok to test |
pentschev
reviewed
Feb 4, 2025
pentschev
approved these changes
Feb 4, 2025
bdice
approved these changes
Feb 10, 2025
jameslamb
approved these changes
Feb 10, 2025
|
I needed 806692a to unblock the devcontainer build. I am not currently sure whether our environment was previously underspecified or if something has changed in conda-forge CUDA packages to break a case that we intended to support. I will follow up, but I want to get this PR in to unblock the downstream chain so I'm to merge it with the additional dependency. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ucxx only needs minor changes here to adapt for the upstream rmm changes.
Contributes to rapidsai/build-planning#104.