Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-24.02 to branch-24.04 #1435

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

GPUtester
Copy link
Contributor

Forward-merge triggered by push to branch-24.02 that creates a PR to keep branch-24.04 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

…nfo() nonvirtual. Remove derived implementations and calls in RMM (#1430)

Closes #1426

As part of #1388, this PR contributes to deprecating and removing all `get_mem_info` functionality from memory resources.  This first PR makes these methods optional without deprecating them. 

 - Makes `rmm::mr::device_memory_resource::supports_get_mem_info()` nonvirtual (and always return false) 
 - Makes `rmm::mr::device_memory_resource::do_get_mem_info()` nonvirtual (and always return `{0, 0}`).
 - Removes all derived implementations of the above.
 - Removes all calls to the above.

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #1430
@GPUtester GPUtester requested a review from a team as a code owner January 23, 2024 09:33
@GPUtester GPUtester requested review from rongou and jrhemstad January 23, 2024 09:33
@GPUtester GPUtester merged commit 9d2800e into branch-24.04 Jan 23, 2024
28 checks passed
@GPUtester
Copy link
Contributor Author

SUCCESS - forward-merge complete.

@github-actions github-actions bot added the cpp Pertains to C++ code label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Pertains to C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants