From beb6c36d3cc1aa655f5f311113ed033dca8c23fb Mon Sep 17 00:00:00 2001 From: Michael Schellenberger Costa Date: Fri, 2 Feb 2024 00:28:36 -0800 Subject: [PATCH 1/3] Change `rmm::exec_policy` to take `async_resource_ref` (#1449) Authors: - Michael Schellenberger Costa (https://github.com/miscco) Approvers: - Mark Harris (https://github.com/harrism) URL: https://github.com/rapidsai/rmm/pull/1449 --- include/rmm/exec_policy.hpp | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/rmm/exec_policy.hpp b/include/rmm/exec_policy.hpp index eacdfa187..5acd062e3 100644 --- a/include/rmm/exec_policy.hpp +++ b/include/rmm/exec_policy.hpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020-2021, NVIDIA CORPORATION. + * Copyright (c) 2020-2024, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,6 +23,7 @@ #include #include +#include #include #include @@ -39,7 +40,7 @@ namespace rmm { * @brief Synchronous execution policy for allocations using thrust */ using thrust_exec_policy_t = - thrust::detail::execute_with_allocator, + thrust::detail::execute_with_allocator, thrust::cuda_cub::execute_on_stream_base>; /** @@ -54,10 +55,10 @@ class exec_policy : public thrust_exec_policy_t { * @param stream The stream on which to allocate temporary memory * @param mr The resource to use for allocating temporary memory */ - explicit exec_policy(cuda_stream_view stream = cuda_stream_default, - rmm::mr::device_memory_resource* mr = mr::get_current_device_resource()) + explicit exec_policy(cuda_stream_view stream = cuda_stream_default, + device_async_resource_ref mr = mr::get_current_device_resource()) : thrust_exec_policy_t( - thrust::cuda::par(rmm::mr::thrust_allocator(stream, mr)).on(stream.value())) + thrust::cuda::par(mr::thrust_allocator(stream, mr)).on(stream.value())) { } }; @@ -68,7 +69,7 @@ class exec_policy : public thrust_exec_policy_t { * @brief Asynchronous execution policy for allocations using thrust */ using thrust_exec_policy_nosync_t = - thrust::detail::execute_with_allocator, + thrust::detail::execute_with_allocator, thrust::cuda_cub::execute_on_stream_nosync_base>; /** * @brief Helper class usable as a Thrust CUDA execution policy @@ -78,11 +79,10 @@ using thrust_exec_policy_nosync_t = */ class exec_policy_nosync : public thrust_exec_policy_nosync_t { public: - explicit exec_policy_nosync( - cuda_stream_view stream = cuda_stream_default, - rmm::mr::device_memory_resource* mr = mr::get_current_device_resource()) + explicit exec_policy_nosync(cuda_stream_view stream = cuda_stream_default, + device_async_resource_ref mr = mr::get_current_device_resource()) : thrust_exec_policy_nosync_t( - thrust::cuda::par_nosync(rmm::mr::thrust_allocator(stream, mr)).on(stream.value())) + thrust::cuda::par_nosync(mr::thrust_allocator(stream, mr)).on(stream.value())) { } }; From f32d35b48fe9c7ad680cd2c78535a2d463d2e73b Mon Sep 17 00:00:00 2001 From: Vyas Ramasubramani Date: Tue, 6 Feb 2024 17:40:07 -0800 Subject: [PATCH 2/3] Exclude tests from builds (#1459) --- python/pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/python/pyproject.toml b/python/pyproject.toml index 1e901b1ab..204d81c3c 100644 --- a/python/pyproject.toml +++ b/python/pyproject.toml @@ -114,6 +114,7 @@ build-dir = "build/{wheel_tag}" cmake.build-type = "Release" cmake.minimum-version = "3.26.4" ninja.make-fallback = true +sdist.exclude = ["*tests*"] sdist.reproducible = true wheel.packages = ["rmm"] From 49f70580111cb10eeb1d0222216d356df70cd8c0 Mon Sep 17 00:00:00 2001 From: Bradley Dice Date: Wed, 7 Feb 2024 10:30:45 -0600 Subject: [PATCH 3/3] Ensure that `ctest` is called with `--no-tests=error`. (#1460) This PR ensures that all calls to `ctest` include the flag `--no-tests=error`. See https://github.com/rapidsai/build-planning/issues/18. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Jake Awe (https://github.com/AyodeAwe) URL: https://github.com/rapidsai/rmm/pull/1460 --- ci/test_cpp.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/test_cpp.sh b/ci/test_cpp.sh index 3bf915e0a..fddd71b9d 100755 --- a/ci/test_cpp.sh +++ b/ci/test_cpp.sh @@ -1,5 +1,5 @@ #!/bin/bash -# Copyright (c) 2020-2023, NVIDIA CORPORATION. +# Copyright (c) 2020-2024, NVIDIA CORPORATION. set -euo pipefail @@ -40,7 +40,7 @@ rapids-logger "Run gtests" cd $CONDA_PREFIX/bin/gtests/librmm/ export GTEST_OUTPUT=xml:${RAPIDS_TESTS_DIR}/ -ctest -j20 --output-on-failure +ctest -j20 --output-on-failure --no-tests=error rapids-logger "Test script exiting with value: $EXITCODE" exit ${EXITCODE}