Skip to content

Commit

Permalink
fix GITHUB_WORKSPACE not being present locally
Browse files Browse the repository at this point in the history
  • Loading branch information
msarahan committed Feb 26, 2025
1 parent d1a5f1b commit 1508ec5
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:
# This job must use a self-hosted runner to record telemetry traces.
runs-on: linux-amd64-cpu4
needs: pr-builder
if: ${{ vars.TELEMETRY_ENABLED == 'true' && !cancelled() }}
if: ${{ vars.TELEMETRY_ENABLED == 'true' && !cancelled() && github.run_attempt == '1' }}
continue-on-error: true
steps:
- name: Telemetry summarize
Expand Down
4 changes: 2 additions & 2 deletions ci/build_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ rattler-build build --recipe conda/recipes/librmm \
--no-build-id \
--channel-priority disabled \
--output-dir "$RAPIDS_CONDA_BLD_OUTPUT_DIR" \
"${RATTLER_CHANNELS[@]}" 2>&1 | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/build.log
"${RATTLER_CHANNELS[@]}" 2>&1 | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/build.log

sccache --show-adv-stats | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/sccache-stats.txt
sccache --show-adv-stats | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/sccache-stats.txt

# remove build_cache directory
rm -rf "$RAPIDS_CONDA_BLD_OUTPUT_DIR"/build_cache
Expand Down
4 changes: 2 additions & 2 deletions ci/build_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ rattler-build build --recipe conda/recipes/rmm \
--channel-priority disabled \
--output-dir "$RAPIDS_CONDA_BLD_OUTPUT_DIR" \
-c "${CPP_CHANNEL}" \
"${RATTLER_CHANNELS[@]}" 2>&1 | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/build.log
"${RATTLER_CHANNELS[@]}" 2>&1 | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/build.log

sccache --show-adv-stats | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/sccache-stats.txt
sccache --show-adv-stats | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/sccache-stats.txt

# See https://github.com/prefix-dev/rattler-build/issues/1424
rm -rf "$RAPIDS_CONDA_BLD_OUTPUT_DIR"/build_cache
Expand Down
4 changes: 2 additions & 2 deletions ci/build_wheel_cpp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ sccache --zero-stats
# Creates artifacts directory for telemetry
source rapids-telemetry-setup

rapids-pip-retry wheel . -w dist -v --no-deps --disable-pip-version-check 2>&1 | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/build.log
rapids-pip-retry wheel . -w dist -v --no-deps --disable-pip-version-check 2>&1 | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/build.log

sccache --show-adv-stats | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/sccache-stats.txt
sccache --show-adv-stats | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/sccache-stats.txt

python -m wheel tags --platform any dist/* --remove

Expand Down
4 changes: 2 additions & 2 deletions ci/build_wheel_python.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ sccache --zero-stats
source rapids-telemetry-setup

PIP_CONSTRAINT="${PWD}/build-constraints.txt" \
rapids-pip-retry wheel . -w dist -v --no-deps --disable-pip-version-check 2>&1 | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/build.log
rapids-pip-retry wheel . -w dist -v --no-deps --disable-pip-version-check 2>&1 | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/build.log

sccache --show-adv-stats | tee ${GITHUB_WORKSPACE}/telemetry-artifacts/sccache-stats.txt
sccache --show-adv-stats | tee ${GITHUB_WORKSPACE:-.}/telemetry-artifacts/sccache-stats.txt

mkdir -p final_dist
EXCLUDE_ARGS=(
Expand Down

0 comments on commit 1508ec5

Please sign in to comment.