Remove FindCUDAToolkit backport
#645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3f66927, `FindCUDAToolkit.cmake` was backported from CMake 3.31 to get https://gitlab.kitware.com/cmake/cmake/-/commit/b38a8e77cb3c8401b3022a68f07a4fd77b290524, which was introduced in CMake 3.28. Since we now require CMake 3.30, we no longer need the backport.
KyleFromNVIDIA
added
improvement
bdice
approved these changes
Feb 24, 2025
|
/merge |
|
Thanks Kyle and Bradley! 🙏 Do we want to drop these pre-commit bits from PR ( #550 ) as well? kvikio/.pre-commit-config.yaml Lines 65 to 68 in 8d8146b |
|
Good find @jakirkham. @KyleFromNVIDIA Could you file a follow-up to clean up those reference to this file in |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/kvikio
that referenced
this pull request
Feb 25, 2025
|
I've opened #647. |
|
I've also opened rapidsai/cudf#18087. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
Follow-up to #645. Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) URL: #647
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3f66927,
FindCUDAToolkit.cmakewas backported from CMake 3.31 to gethttps://gitlab.kitware.com/cmake/cmake/-/commit/b38a8e77cb3c8401b3022a68f07a4fd77b290524, which was introduced in CMake 3.28. Since we now require CMake 3.30, we no longer need the backport.