Improve config handling in cpp and python #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcrimsontianyu
added
breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
kingcrimsontianyu
force-pushed
the
improve-config
branch
from
b8146e0 to
f5652ea
Compare
|
/ok to test |
1 similar comment
|
/ok to test |
|
Forgot about cuFile's |
|
/ok to test |
madsbk
reviewed
Feb 25, 2025
madsbk
reviewed
Feb 25, 2025
|
/ok to test |
2 similar comments
|
/ok to test |
|
/ok to test |
| # TODO: Wrap nicely, maybe as a dataclass? | ||
| # <https://github.com/rapidsai/kvikio/issues/526> | ||
| DriverProperties = cufile_driver.DriverProperties | ||
| properties = cufile_driver.DriverProperties() |
There was a problem hiding this comment.
I think having an instance of DriverProperties() would suffice. So now the settable properties in cufile driver can be set in the following ways:
kvikio.cuda_driver.properties.<prop> = <value>
kvikio.cuda_driver.set("<prop>", <value>) # Can also be used in a "with" statement
kvikio.cuda_driver.set({"<prop>": <value>}) # Can also be used in a "with" statementLet me know if this looks good enough to you @madsbk
kingcrimsontianyu
force-pushed
the
improve-config
branch
from
55e849c to
33b133e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #642
Closes #526
This PR allows the properties in
kvikio.defaultsandkvikio.cufile_driverto be set in a friendly Pythonic way (C++ interface has also been changed). The expression below can appear standalone which sets the properties globally, or in awithstatement which sets the properties via a context manager.