Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow fallback to Make in Python builds #612

Merged
merged 1 commit into from
Feb 3, 2025
Merged

disallow fallback to Make in Python builds #612

merged 1 commit into from
Feb 3, 2025

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#146

Proposes:

  • setting [tool.scikit-build].ninja.make-fallback = false, so scikit-build-core will not silently fallback to using GNU Make if ninja is not available

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 31, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 31, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb mentioned this pull request Jan 31, 2025
Closed
@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: disallow fallback to Make in Python builds disallow fallback to Make in Python builds Feb 3, 2025
@jameslamb jameslamb marked this pull request as ready for review February 3, 2025 14:01
@jameslamb jameslamb requested a review from a team as a code owner February 3, 2025 14:01
@jameslamb jameslamb requested a review from AyodeAwe February 3, 2025 14:01
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 3630b8c into rapidsai:branch-25.04 Feb 3, 2025
58 checks passed
@jameslamb jameslamb deleted the no-make-fallback branch February 3, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @bdice