Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise specific exceptions on HTTP errors instead of RuntimeError #624

Open
TomAugspurger opened this issue Feb 7, 2025 · 0 comments
Open

Comments

@TomAugspurger
Copy link
Contributor

Mentioned in #603 (comment), when we throw an exception while reading a remote file in C++, we currently get a generic RuntimeError in python.

We should be able to translate these to more specific errors (HTTPError, TimeoutError, etc.). Doing a full exception hierarchy like httpx may be a bit much, but at least differentiating between a completed HTTP request with a 500 status code and a timeout is probably worthwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant