Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix activation script name #456

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Fix activation script name #456

merged 2 commits into from
Jan 28, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 28, 2025

This change is necessary after #448.

@vyasr vyasr added bug Something isn't working non-breaking Introduces a non-breaking change labels Jan 28, 2025
@vyasr vyasr self-assigned this Jan 28, 2025
@vyasr vyasr requested a review from a team as a code owner January 28, 2025 05:42
@vyasr vyasr requested review from bdice and removed request for a team January 28, 2025 05:42
@vyasr
Copy link
Contributor Author

vyasr commented Jan 28, 2025 •
edited
Loading

I'm going to merge this now. The failure is because cuml's forward merge PR is blocked rapidsai/cuml#6257. These changes are necessary for other repos to start passing 25.04 devcontainer CI though.

@vyasr vyasr merged commit a31db20 into rapidsai:branch-25.04 Jan 28, 2025
24 of 26 checks passed
@vyasr vyasr deleted the fix/miniforge_call branch January 28, 2025 14:45
bdice pushed a commit to bdice/devcontainers that referenced this pull request Jan 28, 2025
@vyasr @bdice
Fix activation script name (rapidsai#456)
1499140 
This change is necessary after rapidsai#448.
@bdice bdice mentioned this pull request Jan 28, 2025
Merged
bdice added a commit that referenced this pull request Jan 28, 2025
@bdice @trxcllnt @vyasr
Backport Miniforge PRs (#457)
c3bf959 
Backporting the following:
- Switch to miniforge (#448)
- Fix activation script name (#456)

---------

Co-authored-by: Paul Taylor <178183+trxcllnt@users.noreply.github.com>
Co-authored-by: Vyas Ramasubramani <vyasr@nvidia.com>
@bdice bdice mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

Assignees

@vyasr vyasr

Labels
bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasr @bdice