ANN_BENCH: Fix segfault in CAGRA wrapper when moving its graph #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the graph in CAGRA wrapper needs to be relocated to a different memory resource, the old one is destructed before the data is copied. This leads to a segfault during copy. The fix is to retain the old graph pointer until the data is copied.
achirkin
added
bug
tfeher
reviewed
Feb 27, 2025
tfeher
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.04 #733 +/- ##
=============================================
Coverage 84.00% 84.00%
=============================================
Files 18 18
Lines 125 125
=============================================
Hits 105 105
Misses 20 20 ☔ View full report in Codecov by Sentry. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the graph in CAGRA wrapper needs to be relocated to a different memory resource, the old one is destructed before the data is copied. This leads to a segfault during copy. The fix is to retain the old graph pointer until the data is copied.
This error is likely to happen when one runs CAGRA search benchmark sweeping over multiple values of
graph_memory_type.