Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose kmeans to python #729

Open
wants to merge 12 commits into
base: branch-25.04
Choose a base branch
from

Conversation

benfred
Copy link
Member

@benfred benfred commented Feb 26, 2025

No description provided.

@benfred benfred added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Feb 26, 2025
@benfred benfred self-assigned this Feb 26, 2025
Copy link

copy-pr-bot bot commented Feb 26, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cjnolet
Copy link
Member

cjnolet commented Feb 27, 2025

@benfred this looks great, but one of the things we're being asked for quite a bit today is to expose the hierarchical kmeans to Python. Any chance we can also expose those functions? I don't mind doing it as a follow-up, given that this PR is already feature complete.

@benfred
Copy link
Member Author

benfred commented Feb 27, 2025

/ok to test

@benfred benfred marked this pull request as ready for review February 27, 2025 22:20
@benfred benfred requested review from a team as code owners February 27, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants