Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require sphinx<8.2.0, update CODEOWNERS #100

Merged
merged 3 commits into from
Feb 21, 2025
Merged

require sphinx<8.2.0, update CODEOWNERS #100

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c579053
require sphinx<8.2.0
jameslamb Feb 21, 2025
fb1f28c
update CODEOWNERS
jameslamb Feb 21, 2025
1cd822a
Apply suggestions from code review
jameslamb Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,9 @@ docs/ @rapidsai/cugraph-doc-codeowners
# CI code owners
/.github/ @rapidsai/ci-codeowners
/ci/ @rapidsai/ci-codeowners
/.pre-commit-config.yaml @rapidsai/ci-codeowners

# packaging code owners
/.pre-commit-config.yaml @rapidsai/packaging-codeowners
/conda/ @rapidsai/packaging-codeowners
dependencies.yaml @rapidsai/packaging-codeowners
/build.sh @rapidsai/packaging-codeowners
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

repos:
- repo: https://github.com/rapidsai/pre-commit-hooks
rev: v0.4.0
rev: v0.6.0
hooks:
- id: verify-alpha-spec
- id: verify-copyright

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add the hook for codeowners here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

I did not: #100 (comment)

But this is leftover from when I'd attempted that before, and I definitely did not mean to add a new blank line.

- repo: https://github.com/rapidsai/dependency-file-generator
rev: v1.17.0
hooks:
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/all_cuda-128_arch-x86_64.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ dependencies:
- recommonmark
- sphinx-copybutton
- sphinx-markdown-tables
- sphinx>=8
- sphinx>=8,<8.2.0
- sphinxcontrib-websupport
name: all_cuda-128_arch-x86_64
3 changes: 2 additions & 1 deletion dependencies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ dependencies:
- recommonmark
- sphinx-copybutton
- sphinx-markdown-tables
- sphinx>=8
# the ceiling on sphinx can be removed when https://github.com/spatialaudio/nbsphinx/issues/825 is resolved
- sphinx>=8,<8.2.0
- sphinxcontrib-websupport

# this repo only uses conda and 1 major version of CUDA, so
Expand Down
Loading