Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune some seldom used dtype utils #18141

Open
wants to merge 1 commit into
base: branch-25.04
Choose a base branch
from
Open

Prune some seldom used dtype utils #18141

wants to merge 1 commit into from
+51 −139

Conversation

mroeschke
Copy link
Contributor

Description

  • Timedelta.to_arrow didn't need np_to_pa_dtype, nor a custom implementation since we use pylibcudf
  • cudf_dtype_from_pydata_dtype was only used in select_dtypes so moved it there
  • np_to_pa_dtype can largely be replaced by cudf_dtype_to_pa_type and pyarrow.from_numpy_dtype

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 1, 2025
@mroeschke mroeschke self-assigned this Mar 1, 2025
@mroeschke mroeschke requested a review from a team as a code owner March 1, 2025 01:08
@mroeschke mroeschke requested review from vyasr and galipremsagar March 1, 2025 01:08
@mroeschke mroeschke mentioned this pull request Mar 1, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mroeschke