Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protocol for dlpack instead of deprecated function #18134

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Use protocol for dlpack instead of deprecated function #18134

merged 2 commits into from
Mar 1, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Feb 28, 2025

Description

This PR adapts cudf's dlpack tests for compatibility with cupy 13.4, which was just released yesterday on PyPI and containers cupy/cupy#8722 that breaks the legacy toDlpack functionality.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Feb 28, 2025
@vyasr vyasr self-assigned this Feb 28, 2025
@vyasr vyasr requested a review from a team as a code owner February 28, 2025 19:18
@vyasr vyasr requested review from bdice and mroeschke February 28, 2025 19:18
@github-actions github-actions bot added the Python Affects Python cuDF API. label Feb 28, 2025
seberg
seberg approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@seberg seberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it is completely fine in tests (the only way this might fail is a very old cupy versions)

@vyasr vyasr changed the base branch from branch-25.04 to branch-25.02 February 28, 2025 19:37
@raydouglass raydouglass merged commit 09ebf31 into rapidsai:branch-25.02 Mar 1, 2025
117 of 121 checks passed
@vyasr vyasr deleted the fix/cupy_dlpack branch March 1, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg approved these changes

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @seberg @bdice @raydouglass