Support sorted merges in cudf.polars #18075
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
Python
|
/ok to test |
|
/ok to test |
|
/ok to test |
bdice
approved these changes
Feb 27, 2025
| self.schema = schema | ||
| self.key = key | ||
| self.children = (left, right) | ||
| self._non_child_args = (key,) |
There was a problem hiding this comment.
Is this defined above as _non_child? Can something be reused or simplified here?
There was a problem hiding this comment.
I think we need both. The _non_child arguments are needed to serialization/deserialization, among other things. While the _non_child_args are used to execute the IR nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #18026
Checklist