Add CSV Reader options classes to pylibcudf #17412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
github-actions
bot
added
Python
mroeschke
reviewed
Nov 26, 2024
python/cudf/cudf/_lib/csv.pyx
Outdated
| options.set_prefix(prefix) | ||
|
|
||
| if usecols is not None: | ||
| if all([isinstance(col, int) for col in usecols]): |
There was a problem hiding this comment.
Suggested change
| if all([isinstance(col, int) for col in usecols]): | |
| if all(isinstance(col, int) for col in usecols): |
mroeschke
reviewed
Nov 26, 2024
| @@ -54,7 +96,7 @@ def read_csv( | |||
| # detect_whitespace_around_quotes: bool = False, | |||
| # timestamp_type: DataType = DataType(type_id.EMPTY), | |||
| ) -> TableWithMetadata: ... | |||
| def write_csv(options: CsvWriterOptionsBuilder) -> None: ... | |||
There was a problem hiding this comment.
Was this annotation incorrect before?
There was a problem hiding this comment.
No I don't think so. I wanted to stay consistent because I noticed we dropped the None in other PRs.
There was a problem hiding this comment.
Ah I see. IMO we should still include None as the output type cc @wence-
There was a problem hiding this comment.
I'll follow up based on what we decide
mroeschke
reviewed
Nov 26, 2024
mroeschke
reviewed
Nov 26, 2024
mroeschke
reviewed
Nov 26, 2024
mroeschke
reviewed
Nov 26, 2024
| @@ -1,6 +1,7 @@ | |||
| # Copyright (c) 2024, NVIDIA CORPORATION. | |||
|
|
|||
| from collections.abc import Mapping | |||
| from typing import Self | |||
There was a problem hiding this comment.
Since cudf still supports Python 3.10, we'll need to import this from typing_extensions
mroeschke
approved these changes
Nov 26, 2024
|
/merge |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the CSV reader options classes to pylibcudf and plumbs the changes through cudf python.
Checklist