address review

rapidsai · Nov 26, 2024 · db19620 · db19620
1 parent 31d1212
commit db19620
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/python/cudf/cudf/_lib/csv.pyx b/python/cudf/cudf/_lib/csv.pyx
@@ -234,7 +234,7 @@ def read_csv(
         options.set_prefix(prefix)
 
     if usecols is not None:
-        if all([isinstance(col, int) for col in usecols]):
+        if all(isinstance(col, int) for col in usecols):
             options.set_use_cols_indexes(list(usecols))
         else:
             options.set_use_cols_names([str(name) for name in usecols])

diff --git a/python/pylibcudf/pylibcudf/io/csv.pyi b/python/pylibcudf/pylibcudf/io/csv.pyi
@@ -1,7 +1,8 @@
 # Copyright (c) 2024, NVIDIA CORPORATION.
 
 from collections.abc import Mapping
-from typing import Self
+
+from typing_extensions import Self
 
 from pylibcudf.io.types import (
     CompressionType,

diff --git a/python/pylibcudf/pylibcudf/tests/io/test_csv.py b/python/pylibcudf/pylibcudf/tests/io/test_csv.py
@@ -168,7 +168,7 @@ def test_read_csv_dtypes(csv_table_data, source_or_sink, usecols):
     ).build()
     options.set_dtypes(dtypes)
     if usecols is not None:
-        if all([isinstance(col, int) for col in usecols]):
+        if all(isinstance(col, int) for col in usecols):
             options.set_use_cols_indexes(list(usecols))
         else:
             options.set_use_cols_names([str(name) for name in usecols])