Disable custom 2D separable filtering kernels on windows #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disable failing test cases for these internal customers now that they are disabled - if the test failures are resolved we can enable using these kernels on Windows again in the future
grlee77
added
bug
|
Thanks Greg! 🙏 Can you please write up the test failure in a new issue so we have that for future reference? |
|
uploaded the test failures in #771 |
jakirkham
reviewed
Aug 26, 2024
Co-authored-by: jakirkham <jakirkham@gmail.com>
|
@jakirkham, please approve if there are no further comments |
jakirkham
approved these changes
Sep 1, 2024
|
/merge |
|
Thanks for the ping Greg! 🙏 Missed the update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently bundle some custom 2D convolution kernels not present in CuPy. We have additional testing of these internel kernels, but I found that on the Windows platform a subset of these tests currently fail.
This MR disables auto-selection of these kernels on the Windows platform (will always fall back to CuPy's
cupyx.scipy.ndimagekernels in this case). The test cases that are currently known to fail are skipped for now on Windows. Longer term it would be good to resolve the issues with the kernels, restore the test cases and enable use of these kernels on Windows.