[3.x] Instantly disable the place order button #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it is possible to accidentally place 2 orders from one cart, either because they have a broken mouse or they accidentally click twice. There appears to be a race condition where it's actually possible to bypass the check magento does to try and make sure you can't do this.
This PR instantly disables the button so that it is impossible for this to happen (at least, by accident). Previously, this disabled state was based on the
$root.loading
variable which is not instant, as its value is waiting for a watcher and the async fetching functions.I made sure to check and this addition does not break reactivity with the default disabled state. In other words, if the order placing fails, the button will stop being disabled again like it should.