Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance out of stock message #144

Closed
wants to merge 4 commits into from

Conversation

JimmyHoenderdaal
Copy link
Member

@JimmyHoenderdaal JimmyHoenderdaal commented Nov 14, 2024

same as #143
but for v2

jordythevulder
jordythevulder previously approved these changes Nov 15, 2024
@royduin
Copy link
Member

royduin commented Nov 20, 2024

Conflicts 😇

<div v-for="option in item.configurable_options">
@{{ option.option_label }}: @{{ option.value_label }}
</div>
<div v-for="option in item.customizable_options">
@{{ option.label }}: @{{ option.values[0].label || option.values[0].value }}
</div>
<div v-if="!item.is_available" class="text-ct-error text-balance bg-ct-error/5 my-2 max-w-sm p-2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

balance?

Comment on lines +10 to +12
<template v-if="!item.is_available">
<x-rapidez-ct::input.quantity/>
</template>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this?

@JimmyHoenderdaal
Copy link
Member Author

Closed as we only want this for v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants