[3] Enhance out of stock message #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimmyHoenderdaal
requested review from
royduin,
jordythevulder and
Roene-JustBetter
|
Can you add some info and screenshots? I think we also want this in V2? |
Roene-JustBetter
previously approved these changes
Nov 14, 2024
Roene-JustBetter
previously approved these changes
Nov 15, 2024
jordythevulder
previously approved these changes
Nov 15, 2024
BobWez98
previously approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Let's not merge this untill rapidez/core#627 and rapidez/core#628
|
Conflicts 😇 and the core requirement should be bumped: https://github.com/rapidez/core/releases/tag/2.17.0 |
…out-of-stock-cart
JimmyHoenderdaal
dismissed stale reviews from BobWez98, jordythevulder, and Roene-JustBetter
via
1c17902
Roene-JustBetter
previously approved these changes
Dec 3, 2024
BobWez98
requested changes
Dec 4, 2024
|
Checks are failing. |
JimmyHoenderdaal
changed the title
Roene-JustBetter
previously approved these changes
Dec 18, 2024
| @@ -7,7 +7,9 @@ | |||
| </div> | |||
| </td> | |||
| <td class="flex items-center font-medium max-md:w-1/3 md:table-cell *:mx-auto"> | |||
| <x-rapidez-ct::input.quantity/> | |||
| <template v-if="item.is_available"> | |||
| <x-rapidez-ct::input.quantity/> | |||
There was a problem hiding this comment.
Out of scope but we can use the quantity select from the rapidez core?
There was a problem hiding this comment.
Just like the other feedback, its out of scope and we have issues ready for this subject
BobWez98
previously approved these changes
Dec 18, 2024
JimmyHoenderdaal
dismissed stale reviews from BobWez98 and Roene-JustBetter
via
dbf5f74
|
So 2.x doesn't need this (anymore)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes the out of stock message in the cart look nicer
