Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add translation checker workflow #123

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Oct 30, 2024

Adds the translation checker workflow. Will show missing translations for now as it's missing the translations coming from the core itself (those are only in 3.x), however that will be resolved once the composer require is set to 3.x

@Jade-GG Jade-GG requested review from indykoning and royduin October 30, 2024 12:56
lang/nl.json Outdated Show resolved Hide resolved
lang/nl.json Show resolved Hide resolved
@royduin
Copy link
Member

royduin commented Nov 1, 2024

The workflow is failing now, is that correct?

@Jade-GG
Copy link
Collaborator Author

Jade-GG commented Nov 1, 2024

The workflow is failing now, is that correct?

Correct, at this point the translations from the core are missing---those haven't been released yet (i.e. Rapidez 3.x hasn't been released yet).

Once those are released and the composer.json gets updated with 3.x, then we'll get the core translations merged in and the workflow will succeed 🙂

@royduin royduin merged commit 1f09d7d into feature/rapidez-v3 Nov 1, 2024
1 check failed
@royduin royduin deleted the feature/translation-checker-v3 branch November 1, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants