[v1.7.x] Label Templates: add IP addresses to the Network variables (#885) #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* util: add network util functions
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* Label Templates: add IPAddress to the Network vars
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* util/net: rework to allow mocking system ip address retrieval
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* util/net: return all the available network addresses
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* Label Templates: add IPAddresses.{num} to the Network vars
track all available network addresses
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* make generate-mocks
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* tests: add util/net coverage
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
* error strings should not be capitalized
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
---------
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
(cherry picked from commit 5e14e96)
github-actions
bot
added
area/operator
anmazzotti
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACKPORT of #885
(cherry picked from commit 5e14e96)
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
track all available network addresses
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com
Signed-off-by: Francesco Giudici francesco.giudici@suse.com