Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5.x] Do not include Config to MachineRegistration as pointer (#870) #873

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

anmazzotti
Copy link
Contributor

@anmazzotti anmazzotti commented Oct 17, 2024

Backport of #870 for v1.5.x

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti requested a review from a team as a code owner October 17, 2024 08:56
@github-actions github-actions bot added area/operator operator related changes area/tests test related changes labels Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v1.5.x@afcdf10). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             v1.5.x     #873   +/-   ##
=========================================
  Coverage          ?   54.83%           
=========================================
  Files             ?       40           
  Lines             ?     5004           
  Branches          ?        0           
=========================================
  Hits              ?     2744           
  Misses            ?     1970           
  Partials          ?      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidcassany davidcassany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcassany davidcassany merged commit d12f7b1 into rancher:v1.5.x Oct 22, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator operator related changes area/tests test related changes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants