Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linter happy #621

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Make linter happy #621

merged 2 commits into from
Feb 12, 2024

Conversation

frelon
Copy link
Contributor

@frelon frelon commented Feb 12, 2024

Revive linter added a new default rule for unused-parameters, update the code to match.

Also includes commit to update labeler configuration file.

Revive linter added a new default rule for unused-parameters, update the
code to match.

Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon requested a review from a team as a code owner February 12, 2024 08:10
@frelon frelon enabled auto-merge (rebase) February 12, 2024 08:10
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
@frelon frelon disabled auto-merge February 12, 2024 08:16
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d860e0) 53.79% compared to head (74da24c) 53.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #621   +/-   ##
=======================================
  Coverage   53.79%   53.79%           
=======================================
  Files          40       40           
  Lines        6073     6073           
=======================================
  Hits         3267     3267           
  Misses       2519     2519           
  Partials      287      287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frelon frelon merged commit ecde3cc into rancher:main Feb 12, 2024
25 of 26 checks passed
@frelon frelon deleted the fix-lint branch February 12, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant