Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inversed reset options #604

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

anmazzotti
Copy link
Contributor

Normally both options are on by default, but this slipped through.

Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
@anmazzotti anmazzotti requested a review from a team as a code owner January 30, 2024 15:41
@github-actions github-actions bot added the area/operator operator related changes label Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b4f8eb6) 53.79% compared to head (370965c) 53.79%.

Files Patch % Lines
pkg/elementalcli/elementalcli.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #604   +/-   ##
=======================================
  Coverage   53.79%   53.79%           
=======================================
  Files          40       40           
  Lines        6071     6071           
=======================================
  Hits         3266     3266           
  Misses       2519     2519           
  Partials      286      286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@anmazzotti anmazzotti merged commit e523a25 into rancher:main Jan 30, 2024
13 of 14 checks passed
davidcassany pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Andrea Mazzotti <andrea.mazzotti@suse.com>
(cherry picked from commit e523a25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator operator related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants