hostname: set the hostname on the newer location too #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The /etc/hostname file is a symlink file re-created at every elemental boot. The symlink used to point to /usr/local/etc/hostname. For forthcoming images, the symlink will point to /run/elemental/persistent/etc/hostname. Let's stay on the safe side: let's update the hostname at that location too. Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 53.75% 53.79% +0.03%
==========================================
Files 40 40
Lines 6066 6071 +5
==========================================
+ Hits 3261 3266 +5
Misses 2519 2519
Partials 286 286 ☔ View full report in Codecov by Sentry. |
frelon
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /etc/hostname file is a symlink file re-created at every elemental boot. The symlink used to point to /usr/local/etc/hostname. For forthcoming images, the symlink will point to
/run/elemental/persistent/etc/hostname.
Let's stay on the safe side: let's update the hostname at that location too.
Fixes #601