Add hostname to system-data #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/operator
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
- Coverage 53.86% 53.75% -0.11%
==========================================
Files 39 40 +1
Lines 6037 6066 +29
==========================================
+ Hits 3252 3261 +9
- Misses 2500 2519 +19
- Partials 285 286 +1 ☔ View full report in Codecov by Sentry. |
frelon
force-pushed
the
registration-hostname
branch
from
cb87709 to
e36c5bf
Compare
|
This should also be backported to |
frelon
force-pushed
the
registration-hostname
branch
from
e36c5bf to
7eca722
Compare
Add new ${System Data/Runtime/Hostname} key to the registration data
sent from the elemental-register command.
Signed-off-by: Fredrik Lönnegren <fredrik.lonnegren@suse.com>
frelon
force-pushed
the
registration-hostname
branch
from
7eca722 to
8f220ca
Compare
This was referenced Jan 19, 2024
fgiudici
added a commit
to fgiudici/elemental
that referenced
this pull request
Jan 19, 2024
If the (static) hostname is not set, we used to set a rancher-${RANDOM}
one. This anyway prevents DHCP to serve a transient hostname.
In Elemental, at registration time, the hostname is recorded as the
MachineInventory name and from that point onwards it could not be
changed. It will be enforced as the static hostname during the k3s/RKE2
provisioning.
Since we do registration just after the ISO boot, in order to use the
DHCP provided hostname, we should allow the transient name to be set by
the dhcp client (which happens only if the static hostname is not
set) and then take advantage of the new templating value:
${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Drawbacks: if no hostname is provided by the DHCP server or via IP
reverse lookup, and if the MachineName has not been set in the
MachineInventory, the Elemental host will have "localhost" hostname till
k3s/RKE2 provisioning.
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
This was referenced Jan 19, 2024
fgiudici
added a commit
to fgiudici/elemental
that referenced
this pull request
Jan 19, 2024
If the (static) hostname is not set, we used to set a rancher-${RANDOM}
one. This anyway prevents DHCP to serve a transient hostname.
In Elemental, at registration time, the hostname is recorded as the
MachineInventory name and from that point onwards it could not be
changed. It will be enforced as the static hostname during the k3s/RKE2
provisioning.
Since we do registration just after the ISO boot, in order to use the
DHCP provided hostname, we should allow the transient name to be set by
the dhcp client (which happens only if the static hostname is not
set) and then take advantage of the new templating value:
${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Drawbacks: if no hostname is provided by the DHCP server or via IP
reverse lookup, and if the MachineName has not been set in the
MachineInventory, the Elemental host will have "localhost" hostname till
k3s/RKE2 provisioning.
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
fgiudici
added a commit
to fgiudici/elemental
that referenced
this pull request
Jan 29, 2024
If the (static) hostname is not set, we used to set a rancher-${RANDOM}
one. This anyway prevents DHCP to serve a transient hostname.
In Elemental, at registration time, the hostname is recorded as the
MachineInventory name and from that point onwards it could not be
changed. It will be enforced as the static hostname during the k3s/RKE2
provisioning.
Since we do registration just after the ISO boot, in order to use the
DHCP provided hostname, we should allow the transient name to be set by
the dhcp client (which happens only if the static hostname is not
set) and then take advantage of the new templating value:
${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Let's anyway set the racher-${RANDOM} hostname but as a transient one
and before the network stage (so it may be replaced by the DHCP provided
one).
This is a change in behavior: on Elemental booting (before provisioning)
if a hostname has not been set and DHCP provides one, the DHCP hostname
takes precedence over the rancher-${RANDOM} one.
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
fgiudici
added a commit
to fgiudici/elemental
that referenced
this pull request
Jan 31, 2024
If the (static) hostname is not set, we used to set a rancher-${RANDOM}
one. This anyway prevents DHCP to serve a transient hostname.
In Elemental, at registration time, the hostname is recorded as the
MachineInventory name and from that point onwards it could not be
changed. It will be enforced as the static hostname during the k3s/RKE2
provisioning.
Since we do registration just after the ISO boot, in order to use the
DHCP provided hostname, we should allow the transient name to be set by
the dhcp client (which happens only if the static hostname is not
set) and then take advantage of the new templating value:
${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Let's anyway set the racher-${RANDOM} hostname but as a transient one
and before the network stage (so it may be replaced by the DHCP provided
one).
This is a change in behavior: on Elemental booting (before provisioning)
if a hostname has not been set and DHCP provides one, the DHCP hostname
takes precedence over the rancher-${RANDOM} one.
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
fgiudici
added a commit
to rancher/elemental
that referenced
this pull request
Jan 31, 2024
If the (static) hostname is not set, we used to set a rancher-${RANDOM}
one. This anyway prevents DHCP to serve a transient hostname.
In Elemental, at registration time, the hostname is recorded as the
MachineInventory name and from that point onwards it could not be
changed. It will be enforced as the static hostname during the k3s/RKE2
provisioning.
Since we do registration just after the ISO boot, in order to use the
DHCP provided hostname, we should allow the transient name to be set by
the dhcp client (which happens only if the static hostname is not
set) and then take advantage of the new templating value:
${System Data/Runtime/Hostname}
(see rancher/elemental-operator#593)
Let's anyway set the racher-${RANDOM} hostname but as a transient one
and before the network stage (so it may be replaced by the DHCP provided
one).
This is a change in behavior: on Elemental booting (before provisioning)
if a hostname has not been set and DHCP provides one, the DHCP hostname
takes precedence over the rancher-${RANDOM} one.
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new
${System Data/Runtime/Hostname}key to the registration data sent from the elemental-register command.Fixes #591