Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add Arm support for EKS NodeGroup #354

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Feb 6, 2024

What this PR does / why we need it:
Adds support for ARM node groups. The new API field Arm was introduced in the NG properties and disabled by default, and when it is set to true with the appropriate instanceType (i.e a1.large instead of t3.medium) for ARM, a node group will be created based off of the ARM AMI types.

Which issue(s) this PR fixes
Issue rancher/dashboard#11629

Special notes for your reviewer:

To be able to use this feature:

  1. A new operator release needs to be cut
  2. A new release of the operator bumped in Rancher with a new field added in https://github.com/rancher/rancher/tree/release/v2.9/pkg/controllers/management/eks/test files
  3. daily e2e tests might fail until then both of the above are completed

I have tested it by:

  1. Releasing a new operator version from my fork
  2. Bumping Rancher to the above version and building a local container image pushed to the registry (DockerHub in this specific case)
  3. Upgrading the rancher to use the locally built rancher image right after it is installed in e2e tests
helm upgrade rancher rancher-stable/rancher --namespace cattle-system --set bootstrapPassword=admin --set replicas=1 --set hostname=rancher.my.org --set rancherImage="registry/target-repo" --set rancherImageTag="imageTag"
  1. Check one of the nodegroups (ng1) created using the AL2_ARM_64 AMIType and a1.large instanceType while the other nodegroup (nodenametest) with AL2_x86_64 AMIType and t3.medium instanceType.

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@furkatgofurov7 furkatgofurov7 added the kind/enhancement New feature or request label Feb 6, 2024
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner February 6, 2024 11:02
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjura mjura self-requested a review February 6, 2024 15:59
@mjura
Copy link
Contributor

mjura commented Feb 6, 2024

@furkatgofurov7 please backport to release-v2.9

@furkatgofurov7 furkatgofurov7 merged commit 50af05d into rancher:main Feb 7, 2024
7 checks passed
@furkatgofurov7 furkatgofurov7 deleted the add-arm64-ng branch February 7, 2024 10:01
@furkatgofurov7 furkatgofurov7 restored the add-arm64-ng branch February 7, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants