Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VEX related improvements in the build process #1068

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

macedogm
Copy link
Member

@macedogm macedogm commented Jan 9, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes
Issue #1067

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
Comment on lines +14 to +18
# Once this image is migrated to be SLSA compliant and the Go build happens
# inside a build layer, we must pass the version and commit ID to the build,
# similar to what was done in https://github.com/rancher/aks-operator/pull/803 .
# This is just a reference for future changes, because it's needed for our VEX
# work.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🥇

@yiannistri yiannistri merged commit 743322d into rancher:main Jan 9, 2025
6 checks passed
@macedogm macedogm deleted the vex-go-build-improvements branch January 9, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants