Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure non-RKE2 clusters can be searched/filtered by name #12890

Open
richard-cox opened this issue Dec 16, 2024 · 2 comments · Fixed by #13518
Open

Ensure non-RKE2 clusters can be searched/filtered by name #12890

richard-cox opened this issue Dec 16, 2024 · 2 comments · Fixed by #13518
Assignees
@richard-cox @IsaSih
Labels
area/performance area/server-side-pagination kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Milestone
v2.11.0

Comments

@richard-cox
Copy link
Member

richard-cox commented Dec 16, 2024 •
edited
Loading

  • Currently when server-side pagination is enabled (and Add server-side pagination to home page cluster list #11663 is merged) searching/sorting on the home page clusters list is done on prov cluster metadata.name
    • This will also be the case for the cluster management cluster list
  • For RKE2 clusters metadata.name is the human provided name of the cluster
  • For none-RKE2 clusters however metadata.name is the mgmt clusters id (not the human provided mgmt clusters spec.displayName)
  • In discussions with API team on how to resolve, result needs to be wired in

Blocked on rancher/rancher#48509
@richard-cox richard-cox added this to the v2.11.0 milestone Dec 16, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 16, 2024
This was referenced Dec 16, 2024
Open
Merged
@richard-cox richard-cox changed the title Ensure RKE1 clusters can be searched/filtered on by name Ensure RKE1 clusters can be searched/filtered by name Dec 19, 2024
@richard-cox richard-cox mentioned this issue Jan 10, 2025
Open
@richard-cox richard-cox changed the title Ensure RKE1 clusters can be searched/filtered by name Ensure non-RKE2 clusters can be searched/filtered by name Feb 4, 2025
@richard-cox richard-cox mentioned this issue Feb 4, 2025
Open
@richard-cox richard-cox self-assigned this Feb 4, 2025
@richard-cox richard-cox mentioned this issue Feb 5, 2025
Closed
@richard-cox
Copy link
Member Author

Blocked on adding the label to indexed list - trying to sneak in via rancher/steve#485 (comment)

@richard-cox richard-cox mentioned this issue Feb 26, 2025
Merged
7 tasks
@yonasberhe23 yonasberhe23 added the QA/manual-test Indicates issue requires manually testing label Mar 11, 2025
@yonasberhe23
Copy link
Contributor

Requires manual validation.

@IsaSih IsaSih self-assigned this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-cox richard-cox

@IsaSih IsaSih

Labels
area/performance area/server-side-pagination kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this QA/manual-test Indicates issue requires manually testing size/1 Size Estimate 1
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Wire in sorting/filtering clusters on new cluster human name label richard-cox/dashboard
3 participants
@richard-cox @IsaSih @yonasberhe23