Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about how to resolve Chart patch failures #3254

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented Dec 1, 2023

Issue rancher/charts-build-scripts#68

After merging this PR rancher/charts-build-scripts#118, there might be Chart patching failures on charts that have dependencies. Many developers might not be aware of how to resolve patch failures.

So, I created a How to Guide to help them.

Copy link

github-actions bot commented Dec 1, 2023

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@rohitsakala rohitsakala requested a review from a team December 1, 2023 09:00
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rohitsakala rohitsakala merged commit f8bb395 into rancher:dev-v2.8 Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants