Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Support branched charts (non-local workingDir) #14

Open
aiyengar2 opened this issue Feb 4, 2021 · 0 comments
Open

[proposal] Support branched charts (non-local workingDir) #14

aiyengar2 opened this issue Feb 4, 2021 · 0 comments

Comments

@aiyengar2
Copy link
Contributor

Currently, the scripts support only two types of packages:

  • local charts: charts that exist directly in the Source branch
  • forked charts: charts that only exist as a set of patch / overlay / exclude files applied on top of a base

This proposal targets a new type of chart that is a hybrid between local charts and forked charts: branched charts.

What is a branched chart?

A branched chart is a forked chart whose workingDir is directly maintained in another repository / branch.

On merging a change to the target repository / branch, a Github Workflow will automatically pull the target in the workingDir of the target package (instead of running Chart.Prepare()), run make patch to create or update the generated-changes/ directory, and commit it to the Source branch.

Why is this useful?

Branched charts can directly point to an upstream chart, so you can use existing git rebase tools in order to pull in the latest upstream and resolve patch conflicts to cut a new release.

Pushing in a change to these charts also does not require developers to have to view "diff on diff" PRs since you are directly merging the new workingDir into the branch, but you can still call out the difference between your repository and an upstream by viewing the Source branch and do stuff like CRD charts directly on the Source branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants