Skip to content

Commit

Permalink
Merge pull request #196 from nicholasSUSE/fix-regsync-deny-tag
Browse files Browse the repository at this point in the history
removing deny tags when there is a tag to sync
  • Loading branch information
nicholasSUSE authored Feb 25, 2025
2 parents 7aed8c7 + 0fa7dc6 commit 83444bc
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions pkg/regsync/generateconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func GenerateConfigFile() error {
return err
}

// Create the regsync config file
// Create the first regsync config file for tracking images and tags on prime registry
if err := createRegSyncConfigFile(imageTagMap); err != nil {
return err
}
Expand Down Expand Up @@ -282,16 +282,18 @@ sync:`)
fmt.Fprintln(file)
fmt.Fprintln(file, " type: repository")
fmt.Fprintln(file, " tags:")
fmt.Fprintln(file, " deny:")
fmt.Fprintln(file, ` - "*"`)
fmt.Fprintln(file, " allow:")

// We collect all tags and then sort them so there is consistency
// in the update of the regsync file always.
tags := make([]string, 0)
tags = append(tags, imageTagMap[repo]...)
if len(tags) == 0 {
fmt.Fprintln(file, " deny:")
fmt.Fprintln(file, ` - "*"`)
continue
}
sort.Strings(tags)

fmt.Fprintln(file, " allow:")
for _, tag := range tags {
if tag == "" {
continue // skip empty tag
Expand Down

0 comments on commit 83444bc

Please sign in to comment.