Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate custom admin tabs from plugin routes #1418 #1419

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

joshdimanteto
Copy link
Contributor

@joshdimanteto joshdimanteto commented Nov 11, 2024

Description

This PR implements dynamic generation of custom admin tabs based on plugin routes, allowing plugins to define their own specific admin routes that are rendered as tabs on the admin page. This refactor provides flexibility in managing and displaying admin routes per plugin, improving modularity.

Testing instructions

To test these changes, follow the steps below:

  • Run Application: Start the application and navigate to the admin section.
  • Check Admin Tabs: Confirm that tabs in the admin section are generated based on the configured plugin routes and appear as expected.

Agile board tracking

closes #1418

- Implemented dynamic generation of admin tabs using plugin routes
- Updated admin page to render tabs based on configured plugin routes
- Refactored tab generation logic to support custom admin routes for each plugin
@joshdimanteto joshdimanteto force-pushed the generate-custom-admin-tabs-#1418 branch from c469cb6 to 3f0c185 Compare November 11, 2024 15:03
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.11%. Comparing base (5f9dbde) to head (0553a52).

Additional details and impacted files
@@                Coverage Diff                 @@
##           react-18-#1205    #1419      +/-   ##
==================================================
+ Coverage           96.95%   97.11%   +0.15%     
==================================================
  Files                  49       49              
  Lines                1775     1802      +27     
  Branches              497      503       +6     
==================================================
+ Hits                 1721     1750      +29     
+ Misses                 50       48       -2     
  Partials                4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joshdimanteto joshdimanteto force-pushed the generate-custom-admin-tabs-#1418 branch from cf18d80 to 80bdaaa Compare November 11, 2024 15:23
@joshdimanteto joshdimanteto force-pushed the generate-custom-admin-tabs-#1418 branch from 80bdaaa to 0553a52 Compare November 11, 2024 15:27
@joshdimanteto joshdimanteto marked this pull request as ready for review November 18, 2024 16:29
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it works correctly with DG, including setting the default tab to download.

@joshdimanteto joshdimanteto merged commit f50d4f2 into react-18-#1205 Nov 20, 2024
4 checks passed
@joshdimanteto joshdimanteto deleted the generate-custom-admin-tabs-#1418 branch November 20, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants