Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow #1660

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update release workflow #1660

merged 1 commit into from
Jul 23, 2024

Conversation

louise-davies
Copy link
Member

Description

The old release action is a) unmaintained and b) always failed to upload the assets when the release was first created and thus the job needed to be reran. This fixes both those issues.

I tested this on my fork so feel free to verify it works: https://github.com/louise-davies/datagateway

This will also auto-trigger github to fill in it's generated release notes - it also adds a tiny bit of config to that to separate out dependency updates

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Plus auto-generate release notes
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.25%. Comparing base (8cb754d) to head (29dbc01).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1660   +/-   ##
========================================
  Coverage    96.25%   96.25%           
========================================
  Files          170      170           
  Lines         7326     7326           
  Branches      2342     2355   +13     
========================================
  Hits          7052     7052           
  Misses         254      254           
  Partials        20       20           
Flag Coverage Δ
common 95.32% <ø> (ø)
dataview 97.36% <ø> (ø)
download 95.99% <ø> (ø)
search 96.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies merged commit 1e141a4 into develop Jul 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants