Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump @nextcloud/vue from 9.0.0-alpha.4 to 9.0.0-alpha.5 #595

Merged
merged 2 commits into from
Aug 4, 2024
Merged

chore(deps): bump @nextcloud/vue from 9.0.0-alpha.4 to 9.0.0-alpha.5 #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42d80d
chore(deps): bump @nextcloud/vue from 9.0.0-alpha.4 to 9.0.0-alpha.5
dependabot[bot] Jul 20, 2024
a9f71ae
fix: do not use test attributes
raimund-schluessler Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@nextcloud/l10n": "3.1.0",
"@nextcloud/moment": "1.3.1",
"@nextcloud/router": "3.0.1",
"@nextcloud/vue": "9.0.0-alpha.4",
"@nextcloud/vue": "9.0.0-alpha.5",
"@vueuse/components": "^10.11.0",
"bwip-js": "4.5.0",
"date-fns": "^3.6.0",
Expand Down
1 change: 0 additions & 1 deletion src/components/EntityTable/EntityTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ export default {
'aria-label': label,
'model-value': this.allEntitiesSelected,
indeterminate: this.someEntitiesSelected,
'data-testid': 'select-all-checkbox',
title: label,
}
},
Expand Down
3 changes: 1 addition & 2 deletions src/components/EntityTable/Item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,13 @@ License along with this library. If not, see <http://www.gnu.org/licenses/>.

<template>
<div :class="{ 'row--has-status': entity.syncStatus }"
class="row handler"
class="row row--item handler"
@click.exact="() => {mode == 'selection' ? selectEntity() : ''}"
@click.ctrl="selectEntity">
<div class="column column--selection">
<NcCheckboxRadioSwitch v-if="showActions"
:aria-label="t('inventory', 'Select')"
:model-value="isSelected"
data-testid="item-checkbox"
@update:model-value="selectEntity" />
</div>
<div class="column">
Expand Down
6 changes: 3 additions & 3 deletions tests/javascript/unit/components/EntityTable/EntityTable.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ describe('EntityTable.vue', () => {
},
})
store.commit('setSearchString', '')
const itemCheckbox = wrapper.findAll('[data-testid="item-checkbox"] input')
const itemCheckbox = wrapper.findAll('.row--item .checkbox-radio-switch input')
itemCheckbox.at(0).setChecked()
itemCheckbox.at(1).setChecked()
itemCheckbox.at(2).setChecked()
Expand All @@ -160,7 +160,7 @@ describe('EntityTable.vue', () => {
},
})
store.commit('setSearchString', '')
const selectAll = wrapper.find('[data-testid="select-all-checkbox"] input')
const selectAll = wrapper.find('.row--header .checkbox-radio-switch input')
selectAll.setChecked()
let itemsFound = wrapper.vm.selectedItems
let allSelected = wrapper.vm.allEntitiesSelected
Expand Down Expand Up @@ -188,7 +188,7 @@ describe('EntityTable.vue', () => {
},
})
store.commit('setSearchString', '')
const itemCheckbox = wrapper.find('[data-testid="item-checkbox"] input')
const itemCheckbox = wrapper.find('.row--item .checkbox-radio-switch input')
itemCheckbox.setChecked()
let selectedItems = wrapper.vm.selectedItems
let allSelected = wrapper.vm.allEntitiesSelected
Expand Down
Loading