Add script for printing example.test.txt #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raidgar98
added
enhancement
SKNGetIT
previously approved these changes
Oct 19, 2022
Because there is a lot of diffrent version we need to know on which version is current program
raidgar98
commented
Oct 25, 2022
| @@ -0,0 +1,3 @@ | |||
| with open('example.test.txt', 'r') as file: | |||
There was a problem hiding this comment.
In what mode did you open this file? text or binary
with open('example.test.txt', 'rt') as file:
| @@ -0,0 +1,3 @@ | |||
| with open('example.test.txt', 'r') as file: | |||
| for line in file: | |||
| print(line) | |||
There was a problem hiding this comment.
please use logging library
| @@ -1,3 +1,3 @@ | |||
| with open('example.test.txt', 'r') as file: | |||
There was a problem hiding this comment.
Please squash with previous commit
| @@ -1,4 +1,8 @@ | |||
| file_name = 'example.test.txt' | |||
| from sys import argv | |||
There was a problem hiding this comment.
please, don't use sys.argv, use dedicated library: argparse
| @@ -5,4 +5,4 @@ | |||
|
|
|||
| with open(file_name, 'r') as file: | |||
| for line in file: | |||
| print(line) | |||
| print(len(line), line) | |||
There was a problem hiding this comment.
please update this string to be more readable, like:
f'lenght={len(line)}, string={line}'
|
|
||
| with open(file_name, 'r') as file: | ||
| for line in file: | ||
| print(len(line), line) |
There was a problem hiding this comment.
please strip newline from line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Add new script that prints content of example.test.txt or any text file
How it was achieved?
By adding new
printer.pyscript which can be run viapython printer.pyHow to test it?
Create example file, and check is output from program same