Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PFSSwapUpdate message #6511

Open
2 tasks
palango opened this issue Sep 7, 2020 · 0 comments
Open
2 tasks

Create PFSSwapUpdate message #6511

palango opened this issue Sep 7, 2020 · 0 comments
Labels
Component / PFS path finding service integration Component / State Machine Type / Enhancement

Comments

@palango
Copy link
Contributor

palango commented Sep 7, 2020 •
edited
Loading

Sub-issue for #6506

Description

The node will announce it's swapping pairs via a new PFSSwapUpdate message to the PFS'.

This message enables swaps between the source token to the target token uni-directionally.

Fields

  • source_token_address/source_token_network_address
  • target_token_address/target_token_network_address
  • rate premium over the base price (in base points as in the fee update message)
  • validity period (blocks)
  • Maximum size of transfer in token wei (as a way of limiting slippage for the nodes)
  • signature

Tasks

  • Create PFSSwapUpdate message class with the mentioned fields
  • Add tests

Open questions

  • There needs to be a way to cancel the swap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component / PFS path finding service integration Component / State Machine Type / Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@palango