Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .editorconfig #538

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

WieeRd
Copy link

@WieeRd WieeRd commented Dec 17, 2024

EditorConfig is an editor agnostic way to configure project-local settings and is supported by many editors and IDEs out of the box.

I've created .editorconfig based on the indentations being used in the existing files. Since many people have indentation settings set to 2 spaces for JSON and Lua, having .editorconfig in the repository would help them contribute without having to manually tweak their editor settings every time.

@WieeRd
Copy link
Author

WieeRd commented Dec 17, 2024

Also, a lot of JSON files didn't seem to follow the 4 space indentation.
Should I take this opportunity to run prettier on all of them?

@xudyang1
Copy link
Contributor

Also, a lot of JSON files didn't seem to follow the 4 space indentation. Should I take this opportunity to run prettier on all of them?

The formatting issue will be fixed by #512. Once merged, CI can handle it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants