Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6585 scan_id is searchable, added individual field search #6623

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

moellep
Copy link
Member

@moellep moellep commented Dec 22, 2023

@moellep moellep requested review from e-carlin and rorour December 22, 2023 21:25
@moellep
Copy link
Member Author

moellep commented Dec 22, 2023

@e-carlin and @rorour please give this a test (searching, column selection, pdf download). I refactored the client quite a bit and could have introduced new bugs.

Copy link
Contributor

@rorour rorour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "Search Text" is case insensitive but search text in individual fields are not
  • The box for the "Select Search Field" dropdown is very wide. Not sure if it needs to be this wide to accommodate some long field names, but for the longest one I saw (OAV_resolution [um_pixel]) it was still almost twice as wide as it needs to be.
  • Functionally, the "Add Column" dropdown is a big improvement, but visually, the button looked a lot cleaner. Making the text bold might look better, and maybe you could also make it less wide (tighter around the "Add Column" text) since the field names don't actually appear in that box when selected.

@rorour rorour enabled auto-merge (squash) January 4, 2024 21:18
@rorour rorour merged commit dfc4ab7 into master Jan 4, 2024
2 checks passed
@rorour rorour deleted the 6585-raydata-search branch January 4, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants